Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixing GMP #298

Merged
merged 6 commits into from
Sep 19, 2023
Merged

fix: fixing GMP #298

merged 6 commits into from
Sep 19, 2023

Conversation

tcar121293
Copy link
Contributor

fixing minor issues on GMP

Description

use feeRouter instead of specific feeHandler
use tokenAmount and maxGasLimit when calculating fee

Related Issue Or Context

Closes: #

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@tcar121293
fixing minor issues;
0de328a 
Signed-off-by: tcar <[email protected]>
@tcar121293
revert unnecessary change;
92ccb2f 
Signed-off-by: tcar <[email protected]>
@tcar121293
fix depositFns;
0990cff 
Signed-off-by: tcar <[email protected]>
@tcar121293
lint code;
fb2c6f7 
Signed-off-by: tcar <[email protected]>
@tcar121293
fix test;
d77ccd3 
Signed-off-by: tcar <[email protected]>
@tcar121293
fix test;
19ad819 
Signed-off-by: tcar <[email protected]>
@tcar121293 tcar121293 marked this pull request as ready for review September 14, 2023 09:28
@tcar121293 tcar121293 merged commit 41ea37a into main Sep 19, 2023
3 checks passed
@tcar121293 tcar121293 deleted the tcar/minor-fixes branch September 19, 2023 13:45
@MakMuftic MakMuftic mentioned this pull request Sep 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wainola wainola wainola approved these changes

@FSM1 FSM1 FSM1 approved these changes

@mpetrun5 mpetrun5 Awaiting requested review from mpetrun5

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tcar121293 @FSM1 @wainola